-
-
Notifications
You must be signed in to change notification settings - Fork 119
fix: support fetchPriority compatibility for React 18 and 19 #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
sahsahvedov
wants to merge
6
commits into
react-component:master
from
sahsahvedov:fix/fetchpriority-compat
+113
−7
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
981714d
fix: support fetchPriority compatibility for React 18 and 19
088f6f1
refactor: simplify fetchPriority prop mapping
3dc4c6b
refactor: minimize image prop handling diff
fdfafac
refactor: narrow fetchPriority internal typing
c3ec4bf
test: cover fetchPriority in preview group
5f3a754
fix: preserve fetchPriority in preview group
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| describe('getFetchPriorityProps', () => { | ||
| afterEach(() => { | ||
| jest.resetModules(); | ||
| jest.dontMock('react'); | ||
| }); | ||
|
|
||
| it('uses lowercase fetchpriority for React 18', () => { | ||
| jest.doMock('react', () => ({ | ||
| ...jest.requireActual('react'), | ||
| version: '18.3.1', | ||
| })); | ||
|
|
||
| jest.isolateModules(() => { | ||
| const { getFetchPriorityProps } = require('../src/util'); | ||
| expect(getFetchPriorityProps('high')).toEqual({ | ||
| fetchpriority: 'high', | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| it('uses camelCase fetchPriority for React 19', () => { | ||
| jest.doMock('react', () => ({ | ||
| ...jest.requireActual('react'), | ||
| version: '19.2.4', | ||
| })); | ||
|
|
||
| jest.isolateModules(() => { | ||
| const { getFetchPriorityProps } = require('../src/util'); | ||
| expect(getFetchPriorityProps('high')).toEqual({ | ||
| fetchPriority: 'high', | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| it('returns empty props when value is undefined', () => { | ||
| jest.isolateModules(() => { | ||
| const { getFetchPriorityProps } = require('../src/util'); | ||
| expect(getFetchPriorityProps()).toEqual({}); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
useMemocallback can be simplified to improve readability and maintainability. The current implementation uses a longif-else ifchain, which is verbose and harder to maintain when adding or removing props.Consider refactoring this to build the props object more dynamically by separating the generic props from the special case for
fetchPriority.