fix: search input unresponsive when notFoundContent is null and no op… #1199
Conversation
…tions match When notFoundContent is null and search yields no matching options, the search input was immediately clearing typed characters. Root cause: The useEffect that clears searchValue on dropdown close was triggering even when the dropdown was forced closed by emptyListContent, not from an actual user close action. Fix: Track the previous open state and emptyListContent via refs. Only clear searchValue when the dropdown was actually open before and emptyListContent is not preventing the dropdown from showing. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary of ChangesHello @barangezen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a specific bug in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Walkthrough引入两个 ref（ Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant Select as BaseSelect
participant Dropdown as DropdownList
participant Effect as CloseEffect
User->>Select: 输入字符 (onSearch, update input)
Select->>Dropdown: 过滤 options 并渲染
Dropdown-->>Select: emptyListContent = true/false
Note right of Select: prevOpenRef 保存前一次 open 状态
Select->>Effect: open 从 true 变为 false
Effect->>Select: 如果非 multi/combobox 且 emptyListContent == false -> 清理搜索
Effect-->>Select: 否则 不清理（保留输入）
Estimated code review effort🎯 3 (中等复杂) | ⏱️ ~20 分钟 Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively resolves an issue where the search input would incorrectly clear when notFoundContent is set to null and no search results are found. The solution correctly uses useRef to track the previous open state of the dropdown and to access the emptyListContent flag without adding it as a useEffect dependency. This ensures the search value is only cleared when the dropdown is intentionally closed by the user, not when it's hidden due to a lack of matching options. A new test case has been added that accurately covers the bug scenario, confirming the fix. The changes are well-implemented and improve the user experience for the search functionality.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@tests/Select.test.tsx`:
- Around line 2000-2001: Update the placeholder issue URL in the test comment so
it references the real issue: replace the comment line "//
https://github.com/react-component/select/issues/XXX" with the correct issue
link (for example "https://github.com/ant-design/ant-design/issues/56735" or the
actual react-component/select issue number) near the test case "should allow
typing when notFoundContent is null and no options match" in Select.test.tsx;
ensure the updated comment accurately reflects the relevant repository and issue
number.
|
@barangezen is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
1 participant
🤔 This is a ...
🔗 Related Issues
Fixes: ant-design/ant-design#56735
Problem
When
notFoundContent={null}andshowSearchis enabled, typing a character with no matching options causes the input to immediately clear.Solution
The
useEffectthat clearssearchValueon dropdown close was triggering even whenemptyListContentprevented the dropdown from opening.Fixed by tracking previous open state via ref - only clear
searchValuewhen dropdown actually closes (was open → now closed), not when it was never opened.Test Plan
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.