chore: switch to tinyglobby#2680
chore: switch to tinyglobby#2680benmccann wants to merge 2 commits intoreact-native-community:mainfrom
Conversation
szymonrybczak
left a comment
There was a problem hiding this comment.
What's the performance difference between fast-glob and tinyglobby?
|
Looks like the CI for this change is failing because Jest is outdated, so we'll either need to upgrade Jest or wait for a new release of |
|
@benmccann any chance you could measure the perf difference in this project? |
8c21c94 to
c6bf39e
Compare
|
I've updated this PR to use the latest |
| "@types/glob": "^7.1.1", | ||
| "@types/jest": "^26.0.15", | ||
| "@types/node": "^20.0.0", | ||
| "@types/picomatch": "^4.0.2", |
There was a problem hiding this comment.
do we need this? picomatch is a transitive dep
There was a problem hiding this comment.
It was because of the type-checking during the build process. fdir (one of the dependencies of tinyglobby) uses picomatch in its types, but doesn't declare a dependency on @types/picomatch, so it failed without this
I think no one else has hit it because it's quite rare to type-check your dependencies
|
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |

Summary
https://npmgraph.js.org/?q=fast-glob - 17 dependencies
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies
Test Plan
No new functionality was added, so this should be covered by existing tests
Checklist
react-nativecheckout (instructions).