fix(ios): populate missing linkMetadata values from URL fetch#1737
Open
MathieuWhite wants to merge 1 commit intoreact-native-share:mainfrom
Open
fix(ios): populate missing linkMetadata values from URL fetch#1737MathieuWhite wants to merge 1 commit intoreact-native-share:mainfrom
MathieuWhite wants to merge 1 commit intoreact-native-share:mainfrom
Conversation
- Defer UIActivityViewController initialization and presentation until the LPMetadataProvider fetch completes, so fetched values can fill in any missing fields in the custom linkMetadata before the delegate is called - Remove fetchMetadataForURL calls from itemForActivityType which were triggering redundant concurrent fetches, once when UIActivityViewController was initialized and called the delegate, and again each time the user tapped an activity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Related to #1690
Test Plan
Tested using
activityItemSourceswith a customlinkMetadatatitle and a URL placeholder on an iOS simulator.fetchMetadataForURLis no longer called redundantly fromitemForActivityTypeRNShareActivityItemSourcedeallocates after the share sheet is dismissed with no leaked objects in the memory graph debuggerThe following screenshots use the same
activityItemSourcesoptions as the example included in this PR.Before — original code: share sheet displays only the custom title with no thumbnail since the URL fetch completes after the delegate is called

After — with fix: share sheet displays both the custom title and the thumbnail fetched from the URL metadata since presentation is deferred until the fetch completes
