Fix flaky test: ESM module loading race condition in test_subcomponent_notation#1315
Merged
Archmonger merged 5 commits intomainfrom Dec 12, 2025
Merged
Fix flaky test: ESM module loading race condition in test_subcomponent_notation#1315Archmonger merged 5 commits intomainfrom
Archmonger merged 5 commits intomainfrom
Conversation
Co-authored-by: Archmonger <16909269+Archmonger@users.noreply.github.com>
Co-authored-by: Archmonger <16909269+Archmonger@users.noreply.github.com>
Co-authored-by: Archmonger <16909269+Archmonger@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Determine cause of flaky failure and implement solution
Fix flaky test: ESM module loading race condition in test_subcomponent_notation
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests
test_subcomponent_notation_as_str_attrsandtest_subcomponent_notation_as_obj_attrswere failing intermittently withCannot read properties of null (reading 'useContext'). The issue was a race condition where react-bootstrap attempted to access React's context API before its peer dependencies were fully initialized in the ESM module graph.Fix:
react-isbeforereact-bootstrapto ensure proper module loading orderChecklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.