Skip to content

Add devcontainer configuration#1344

Open
JamesHutchison wants to merge 4 commits intoreactive-python:mainfrom
JamesHutchison:add-devcontainer
Open

Add devcontainer configuration#1344
JamesHutchison wants to merge 4 commits intoreactive-python:mainfrom
JamesHutchison:add-devcontainer

Conversation

@JamesHutchison
Copy link
Contributor

Description

Adds a developer container configuration and updates all references to Python 3.9 to 3.11

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

Copy link
Contributor Author

@JamesHutchison JamesHutchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to clean this up and do a clean rebuild.

One consideration is that I don't see a way to spawn a test server that you can easily tweak. I have a non-committed main.py. It would be a better practice if someone could just grab a launch config and start a server that they can hand test (in my case, I was testing that disabling javascript indeed shows the noscript page)

Comment on lines +7 to +14
// "remoteUser": "vscode",
// "containerEnv": {
// "BUN_INSTALL": "/home/vscode/.bun"
// },
// "remoteEnv": {
// "BUN_INSTALL": "/home/vscode/.bun",
// "PATH": "/home/vscode/.bun/bin:${containerEnv:PATH}"
// },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove

"ms-python.python",
"ms-python.vscode-pylance",
"charliermarsh.ruff",
"ms-playwright.playwright"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extensions were plugged in with AI and should be updated to respect a sane workflow. No idea what this playwright extension is.


# --- IDE ---
.idea
.vscode
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the .idea folder is intended to be private to a user, this is not the case for .vscode which is intended to be a workspace specific configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant