[useCallback] Rephrase sentence for removing Effect dependencies#8012
Closed
rammba wants to merge 1 commit intoreactjs:mainfrom
Closed
[useCallback] Rephrase sentence for removing Effect dependencies#8012rammba wants to merge 1 commit intoreactjs:mainfrom
rammba wants to merge 1 commit intoreactjs:mainfrom
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Contributor
Author
|
I just realized there is a section about moving data inside an Effect. This can be abandoned because I misunderstood the sentence. |
rammba
deleted the
features/rephrase-removing-effect-dependencies-in-useCallback
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I understood the intention of the current sentence correctly, it should say that function should be moved outside of an Effect, because it's an explanation of
Removing Effect Dependenciesarticle. I just wrote that intention explicitly.Note: This PR has a conflict with #8011.