Update LiveData value when becoming active#6301
Open
RemiLatapy wants to merge 2 commits intorealm:mainfrom
Open
Update LiveData value when becoming active#6301RemiLatapy wants to merge 2 commits intorealm:mainfrom
RemiLatapy wants to merge 2 commits intorealm:mainfrom
Conversation
Allow LiveData to stay up to date, especially when resuming an activity
cmelchior
suggested changes
Nov 16, 2018
Contributor
cmelchior
left a comment
cmelchior
left a comment
There was a problem hiding this comment.
Hi @RemiLatapy
Thank you for doing this 👏
I tested this and it looks like calling it here is correct vs. the constructor as it currently does. However, if we just merge this it will actually set the same value twice when constructing the LiveData, which we want to avoid.
If you remove the call to setValue() in the constructor I think we can merge this.
Also, it looks like you need to sign our CLA: https://github.com/realm/realm-java/blob/master/CONTRIBUTING.md#cla
RemiLatapy
commented
Dec 6, 2018
Author
RemiLatapy
left a comment
RemiLatapy
left a comment
There was a problem hiding this comment.
I made some changes to avoid double call
Contributor
|
@cmelchior Looks like this needs another review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow LiveData to stay up to date, especially when resuming an activity
It solves this issue: https://stackoverflow.com/questions/49981734/observer-for-android-livedata-not-called-but-it-is-with-observeforever