feat: expose MSAL extraQueryParams prop#57
Open
dogoku wants to merge 1 commit intorecognizegroup:mainfrom
Open
feat: expose MSAL extraQueryParams prop#57dogoku wants to merge 1 commit intorecognizegroup:mainfrom
dogoku wants to merge 1 commit intorecognizegroup:mainfrom
Conversation
Author
|
I have a few more changes, but I wanted to see if you wanted all in one PR or separate ones
On a side note, I have also noticed that there is a fundamental difference between the implementation of iOS and Android versions of the plugin. iOS uses Multi-account mode where as Android uses Single-Account mode. (See docs for details) This results in difference in behavior between the platforms and even a couple of small bugs. I have no preference to use multi vs single but I am curious what let to this difference in implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the
extraQueryParamsprop from MSAL which allows us to define additional query parameters for the generated URL.The specific use-case is to set the
ui_localesquery parameter, to control the language of the MS auth pages.