Fix StaticCallOnNonStaticToInstanceCallRector for same-class calls #7876
+48
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling a non-static method statically from within the same class, convert to $this->method() instead of skipping. This eliminates the PHP deprecation warning for non-static method called statically. Calls to ancestor methods (e.g., Grandpa::method() from a descendant) are still skipped as they are valid non-static usage.
Member
|
Looks good to me, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StaticCallOnNonStaticToInstanceCallRector rule was skipping the case where the static call was to a method that was implemented in the same class or a superclass. But it should actually only skip if it is a superclass. For the same class, it makes more sense to convert the call to a method call to the current instance.
Fixes rectorphp/rector#9613