fix: OOM crash in RemoveUnusedVariableAssignRector#7964
Merged
samsonasik merged 1 commit intorectorphp:mainfrom Apr 7, 2026
Merged
fix: OOM crash in RemoveUnusedVariableAssignRector#7964samsonasik merged 1 commit intorectorphp:mainfrom
samsonasik merged 1 commit intorectorphp:mainfrom
Conversation
Member
|
@calebdw could you rebase latest main branch so all e2e test can green, thank you. |
samsonasik
reviewed
Apr 7, 2026
rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Apr 7, 2026
rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php
Outdated
Show resolved
Hide resolved
22300d6 to
7f8dca4
Compare
samsonasik
requested changes
Apr 7, 2026
7f8dca4 to
e43f02a
Compare
samsonasik
approved these changes
Apr 7, 2026
Member
|
Thank you @calebdw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#9733
Problem
The
NoDiscardattribute check usedAstResolver::resolveClassMethodOrFunctionFromCall()which, for each call expression, would:MutatingScopeobjects)getTraits(true)$parsedFileNodescacheFor classes like
Carbon\CarbonPeriodwith deep trait hierarchies, this caused unbounded memory growth leading to OOM.Fix
I replaced the expensive AST-based resolution with PHPStan's lightweight ReflectionProvider API, this checks
NoDiscardvia PHPStan's reflection layer without parsing any source files.