Skip classes with Symfony 7.1 Workflow listener attributes#923
Merged
TomasVotruba merged 3 commits intorectorphp:mainfrom Mar 6, 2026
Merged
Conversation
EventListenerToEventSubscriberRector now skips classes that use any of the 7 workflow listener attributes introduced in Symfony 7.1, not just AsEventListener. Fixes rectorphp/rector#9685
TomasVotruba
reviewed
Mar 4, 2026
rules/CodeQuality/Rector/Class_/EventListenerToEventSubscriberRector.php
Outdated
Show resolved
Hide resolved
Member
|
Thank you💪 Can you fix CI as well? |
Contributor
Author
|
@TomasVotruba Hi, CI fixed |
Member
|
Awesome, thank you for contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
hasAsListenerAttribute()to also skip classes using Symfony 7.1 workflow attributes (AsTransitionListener,AsGuardListener,AsCompletedListener, etc.) — not justAsEventListener.Fixes rectorphp/rector#9685