Port 1-084_validate_prune_templates to Ginko#1089
Port 1-084_validate_prune_templates to Ginko#1089trdoyle81 wants to merge 2 commits intoredhat-developer:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
trdoyle81
force-pushed
the
GTIOPS-7206-1-084-Port_validate_prune_templates-to-ginko
branch
from
97ca9ab to
e001cf0
Compare
|
/retest |
|
/retest-required |
trdoyle81
force-pushed
the
GTIOPS-7206-1-084-Port_validate_prune_templates-to-ginko
branch
2 times, most recently
from
1d19949 to
ac9d0ad
Compare
| app.SetNamespace("openshift-gitops") | ||
|
|
||
| // application spec | ||
| Expect(unstructured.SetNestedField(app.Object, "default", "spec", "project")).To(Succeed()) |
There was a problem hiding this comment.
Are there any challenges you see in adding the app spec using the schema?
There was a problem hiding this comment.
Thanks for the suggestion. I've changed to use the struct from the argoproj schema for CR creation so it's the same as the 1-120 test.
Signed-off-by: Triona Doyle <bot@example.com>
Signed-off-by: Triona Doyle <bot@example.com>
trdoyle81
force-pushed
the
GTIOPS-7206-1-084-Port_validate_prune_templates-to-ginko
branch
from
f53cd44 to
804715c
Compare
|
@trdoyle81: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
What type of PR is this?
What does this PR do / why we need it:
Porting test from Kuttl to Ginko. The test validates that Argo CD correctly prunes resources with duplicate GroupVersionKinds (GVKs) when executing a sync via the Argo CD CLI
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #GITOPS-7206
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
export GINKGO_TEST_SUITE="sequential"
export GINKGO_TEST="1-084_validate_prune_templates"
./bin/ginkgo -v -focus $GINKGO_TEST -r ./test/openshift/e2e/ginkgo/$GINKGO_TEST_SUITE