Skip to content

[RHIDP#10991]: Document custom transformers for user provisioning#1767

Merged
themr0c merged 20 commits intoredhat-developer:mainfrom
themr0c:RHIDP-10991-custom-transformers
Apr 2, 2026
Merged

[RHIDP#10991]: Document custom transformers for user provisioning#1767
themr0c merged 20 commits intoredhat-developer:mainfrom
themr0c:RHIDP-10991-custom-transformers

Conversation

@themr0c
Copy link
Copy Markdown
Member

@themr0c themr0c commented Feb 9, 2026

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.5+
Issue: https://redhat.atlassian.net/browse/RHIDP-10991
Preview: N/A

Summary

Add documentation for creating custom transformers to provision users from external identity providers (GitHub, Azure, GitLab, LDAP) to the RHDH software catalog.

New modules

  • proc-create-a-custom-transformer-to-provision-users-from-github-to-the-software-catalog.adoc
  • proc-create-a-custom-transformer-to-provision-users-from-azure-to-the-software-catalog.adoc
  • proc-create-a-custom-transformer-to-provision-users-from-gitlab-to-the-software-catalog.adoc
  • proc-create-a-custom-transformer-to-provision-users-from-ldap-to-the-software-catalog.adoc

Updated assemblies

Each custom transformer module is included in the corresponding authentication assembly:

  • assembly-enable-authentication-with-github.adoc
  • assembly-enable-authentication-with-microsoft-azure.adoc
  • assembly-enable-authentication-with-gitlab.adoc
  • assembly-enable-authentication-with-rhbk.adoc (LDAP custom transformer)

CQA compliance

All new modules pass CQA checks. Includes a fix to CQA-10 _title_to_id_form() to handle {azure-short} attribute mapping.

@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented Feb 9, 2026

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1767/ @ 4/2/2026, 7:10:05 PM

@themr0c themr0c requested a review from JessicaJHee February 9, 2026 15:03
@themr0c themr0c force-pushed the RHIDP-10991-custom-transformers branch from 8dae077 to a02f687 Compare February 17, 2026 11:52
@themr0c themr0c force-pushed the RHIDP-10991-custom-transformers branch from a02f687 to 425812f Compare February 17, 2026 12:05
@themr0c themr0c force-pushed the RHIDP-10991-custom-transformers branch from 425812f to dc5f5ef Compare February 17, 2026 12:08
@themr0c themr0c force-pushed the RHIDP-10991-custom-transformers branch from dc5f5ef to 045c875 Compare February 17, 2026 12:15
@themr0c themr0c force-pushed the RHIDP-10991-custom-transformers branch from 045c875 to 887feca Compare February 17, 2026 12:29
@themr0c themr0c force-pushed the RHIDP-10991-custom-transformers branch from 887feca to bc58a65 Compare February 17, 2026 12:35
@themr0c themr0c force-pushed the RHIDP-10991-custom-transformers branch from bc58a65 to 41b651b Compare February 17, 2026 12:43
@themr0c themr0c marked this pull request as ready for review February 17, 2026 12:45
@themr0c themr0c force-pushed the RHIDP-10991-custom-transformers branch from 41b651b to 36194a1 Compare February 17, 2026 12:47
@themr0c themr0c force-pushed the RHIDP-10991-custom-transformers branch from 36194a1 to f943ab1 Compare February 17, 2026 12:54
@themr0c themr0c force-pushed the RHIDP-10991-custom-transformers branch from f943ab1 to 08abbb6 Compare February 17, 2026 13:02
@themr0c themr0c force-pushed the RHIDP-10991-custom-transformers branch from 08abbb6 to 5eedc2f Compare February 17, 2026 14:53
themr0c and others added 12 commits April 1, 2026 19:29
…, and LDAP

Add procedures for creating custom transformers to provision users from
GitHub, Azure, GitLab, and LDAP to the software catalog. Update auth
assemblies to include the new modules and expand abstracts to mention
custom transformer support. Fix xrefs to use correct IDs with context
suffixes, and fix GitLab module copy-paste errors (GitHub -> GitLab).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Convert Verification sections from unnumbered to numbered lists in
GitHub, Azure, and GitLab custom transformer modules. Fix Azure module
referencing GitHub instead of Azure in verification step.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Shorten assembly abstracts to under 300 chars
- Add [role="_abstract"] to all four modules
- Add _{context} suffix to all module IDs
- Replace hardcoded "Azure" with {azure-short} attribute
- Replace hardcoded "Backstage" with {backstage} attribute
- Attach [IMPORTANT] blocks to last procedure step with +
- Convert LDAP verification list to numbered

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CQA-10 derives the module ID and filename from the title text.
Using {azure-short} in the title resolves to empty during that process,
producing a broken ID. Keep Azure hardcoded in the title only.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The ID is explicitly set, so the attribute in the title won't affect it.
This satisfies CQA-16 (no hardcoded product names).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The LDAP provisioning module is included in the RHBK assembly, so the
LDAP custom transformer module belongs there too, after the RHBK
custom transformer.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The prerequisite xref pointed to a non-existent ID. Updated to
reference the correct enable-user-provisioning-with-ldap_{context}.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update include path for renamed Azure transformer module, replace
hardcoded Azure with {azure-short} in plugin migration table,
add content type to ref-deprecated-plugins, fix list continuation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Apply lhite8041 review feedback: remove second {product} reference,
remove extra colon, add missing period, capitalize "See the", reword
verification step.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…e link

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove hard-to-maintain synchronization log examples from transformer
modules. Revert unrelated changes to dynamic plugins reference files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented Apr 1, 2026

Content Quality Assessment Results

CQA Report

  • CQA-00a: Orphaned modules
  • CQA-00b: Directory structure
  • CQA-01: Vale AsciiDoc DITA compliance
  • CQA-02: Verify assembly structure
  • CQA-03: Verify content type metadata (1 issues)
    • [AUTOFIX] modules/extend_dynamic-plugins-reference/ref-deprecated-plugins.adoc: Line 1: Missing :_mod-docs-content-type: -- add REFERENCE
  • CQA-04: Verify module templates
  • CQA-05: Verify required modular elements (2 issues)
    • [MANUAL] modules/extend_dynamic-plugins-reference/ref-deprecated-plugins.adoc: Missing [id="..._{context}"] topic ID
    • [MANUAL] modules/extend_dynamic-plugins-reference/ref-deprecated-plugins.adoc: Has 0 H1 titles (should be exactly 1)
  • CQA-06: Verify assemblies follow official template (one user story)
  • CQA-07: Verify TOC depth (max 3 levels)
  • CQA-08: Verify short description content quality
  • CQA-09: Verify short description format
  • CQA-10: Verify titles are brief, complete, and descriptive
  • CQA-11: Verify procedure prerequisites
  • CQA-12: Verify grammar and style (Vale)
  • CQA-13: Verify content matches declared type
  • CQA-14: Verify no broken links
  • CQA-15: Check redirects
  • CQA-16: Verify official product names
  • CQA-17: Verify legal disclaimers for preview features (1 issues)
    • [MANUAL] modules/configure_configuring-rhdh/proc-configure-an-rhdh-instance-with-a-tls-connection-in-kubernetes.adoc: Line 75: Mentions 'Technology Preview' but may not include official disclaimer snippet

Summary

Checks: 19 total, 16 pass, 3 fail
Issues: 4 total (1 autofixable, 3 manual, 3 delegated)
Run node build/scripts/cqa/index.js --fix --all to auto-resolve 1 issue.


Automated CQA check run on the entire repository — 2026-04-02 19:06:02 UTC

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented Apr 1, 2026

Copy link
Copy Markdown
Member

@JessicaJHee JessicaJHee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already looking great! Left a few suggestions :)

themr0c and others added 4 commits April 2, 2026 20:45
…sers-from-github-to-the-software-catalog.adoc

Co-authored-by: Jessica He <jessicahe4741@gmail.com>
Add notes in verification steps to check that custom transformations
are reflected in user and group entities. Fix Vale suggestions:
backtick UserEntity/GroupEntity, replace "desired" with "required".

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
After exporting the dynamic plugin, users need to publish and enable it.
Added a step linking to the "Add a custom dynamic plugin to RHDH"
section in the Installing and viewing plugins guide, across all 5
provider-specific custom transformer procedures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 2, 2026

@themr0c
Copy link
Copy Markdown
Member Author

themr0c commented Apr 2, 2026

/cherry-pick release-1.9-post-cqa

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@themr0c: once the present PR merges, I will cherry-pick it on top of release-1.9-post-cqa in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.9-post-cqa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@themr0c: #1767 failed to apply on top of branch "release-1.9-post-cqa":

Applying: RHIDP-10991: Add custom transformer modules for GitHub, Azure, GitLab, and LDAP
Applying: RHIDP-10991: Fix CQA-03 verification lists and Azure copy-paste error
Applying: RHIDP-10991: Fix CQA compliance issues in custom transformer modules
Applying: RHIDP-10991: Restore hardcoded Azure in title to preserve ID/filename
Applying: RHIDP-10991: Use {azure-short} in Azure module title for CQA-16
Applying: RHIDP-10991: Include LDAP custom transformer in RHBK auth assembly
Applying: RHIDP-10991: Fix broken xref in LDAP custom transformer module
Applying: Fix CQA issues after rebase on main
Using index info to reconstruct a base tree...
M	modules/extend_dynamic-plugins-reference/ref-deprecated-plugins.adoc
M	modules/shared/proc-enable-plugins-added-in-the-rhdh-container-image.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/shared/proc-enable-plugins-added-in-the-rhdh-container-image.adoc
Auto-merging modules/extend_dynamic-plugins-reference/ref-deprecated-plugins.adoc
CONFLICT (content): Merge conflict in modules/extend_dynamic-plugins-reference/ref-deprecated-plugins.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0008 Fix CQA issues after rebase on main

Details

In response to this:

/cherry-pick release-1.9-post-cqa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Peer review done 📘 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants