chore(e2e): fix e2e tests on release-1.9 branch#85
Open
gashcrumb wants to merge 2 commits intoredhat-developer:release-1.9from
Open
chore(e2e): fix e2e tests on release-1.9 branch#85gashcrumb wants to merge 2 commits intoredhat-developer:release-1.9from
gashcrumb wants to merge 2 commits intoredhat-developer:release-1.9from
Conversation
The e2e tests were failing due to three issues: - isolated-vm native module build failures during yarn install - Running yarn install from plugin directory instead of workspace root - Missing TypeScript declaration files required for plugin builds This fix: - Uses YARN_ENABLE_SCRIPTS=false to skip native module builds - Installs dependencies from workspace root (workspaces/tech-radar) - Runs yarn tsc at workspace level before building individual plugins - Improves error logging to show detailed failure information Assisted-by: Claude Code Signed-off-by: Tomas Kral <tkral@redhat.com>
This change updates the CLI e2e test spec so that it prints the full output of whatever command fails during execution. This change also includes some tidying of the e2e test output in general so it's hopefully easier to follow, for example avoiding jest's console.log wrapper. Assisted-by: Cursor Desktop rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
gashcrumb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings over some e2e test fixes and additional logging in case of problems over to the release-1.9 branch to ensure the tests work if we need to release an older CLI patch.