DEV: (cmds) update TS cmd pages for multiple aggregators support#2949
DEV: (cmds) update TS cmd pages for multiple aggregators support#2949dwdougherty wants to merge 3 commits intoDOC-6334from
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
Thank you, @kaitlynmichael! |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| per time series, aggregates samples into time buckets, where: | ||
|
|
||
| - `aggregator` takes one of the following aggregation types: | ||
| - `aggregationType` takes one or more of the following aggregation types: |
There was a problem hiding this comment.
Please add a note that whitespace are not allowed. (Like in TS.MRANGE FILTER expression)
Whitespaces are not allowed in an aggregation types expression.
| per time series, aggregates samples into time buckets, where: | ||
|
|
||
| - `aggregator` takes one of the following aggregation types: | ||
| - `aggregationType` takes one or more of the following aggregation types: |
There was a problem hiding this comment.
aggregationTypetakes one or more of the following aggregation types:
I think it is wrong to say that, as each aggregator takes one aggregator.
I suggest using aggregators and describe it as one or more comma-separated aggregations (like in TS.MRANGE FILTER filterExpr...)
| - `aggregationType` takes one or more of the following aggregation types: | ||
|
|
||
| | `aggregator` | Description | | ||
| | `aggregationType` | Description | |
There was a problem hiding this comment.
Please change back to aggregator
| token: TWA | ||
| type: pure-token | ||
| name: aggregator | ||
| - name: aggregationType |
There was a problem hiding this comment.
Suggest renaming to aggregators
| the dataset size to 1,440 data points (24 hours x 60 minutes = 1,440 minutes). | ||
|
|
||
| The range query commands let you specify an aggregation function and bucket size. | ||
| The range query commands let you specify one or more aggregation function and bucket size. |
3 participants
Redis 8.8 feature
Note
Low Risk
Low risk: documentation-only updates, but they change command signatures and examples, so inaccuracies could mislead users if the syntax is wrong.
Overview
Updates RedisTimeSeries range-query docs (
TS.RANGE,TS.REVRANGE,TS.MRANGE,TS.MREVRANGE) to document multiple aggregators via comma-separatedAGGREGATION aggregationType[,aggregationType ...], replacing the previous single-aggregatoroneofargument.Refreshes examples and the TimeSeries aggregation guide to show multi-aggregator usage (e.g.,
min,avg,max), notes thatGROUPBY/REDUCEisn’t allowed when multiple aggregators are specified, and regenerates the related railroad-diagram SVGs to match the new syntax.Written by Cursor Bugbot for commit 0f91ed0. This will update automatically on new commits. Configure here.