fix: correct OTel instrument kind for db.client.connection.count and db.client.connection.pending_requests#2953
Open
elena-kolevska wants to merge 1 commit intoredis:mainfrom
Open
Conversation
Signed-off-by: Elena Kolevska <elena@kolevska.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two client observability metrics (
db.client.connection.countanddb.client.connection.pending_requests) changed from a gauge to an UpDownCounter. This Pr brings the docs in alignment with the change.Note
Low Risk
Low risk docs/spec update: only the metric metadata in
data/client_obs_metrics.jsonchanges, with no runtime code impact. Risk is limited to consumers relying on the previous Gauge/async semantics for these two metric definitions.Overview
Updates the client observability metrics spec to reflect that
db.client.connection.countanddb.client.connection.pending_requestsare synchronousUpDownCounters rather than observable Gauges.This changes their declared
type,otel.instrument_kind, andasync/observableflags, and removes wording that described them as async metrics.Written by Cursor Bugbot for commit 0cd7ba1. This will update automatically on new commits. Configure here.