feat: implement diagnostic channels for observability#3195

Merged

PavelPashov merged 42 commits intoredis:masterfrom

logaretm:feat/tracing-channel

Apr 2, 2026

Commits on Mar 27, 2026

feat: add TracingChannel support with argument sanitization

logaretm
and
claude
committed
test: add comprehensive unit tests for sanitizeArgs

logaretm
and
claude
committed
refactor: use ? placeholder for redacted args

logaretm
and
claude
committed
refactor: move OTel command metrics to TracingChannel subscribers

logaretm
and
claude
committed
refactor: remove NoopCommandMetrics class

logaretm
and
claude
committed
refactor: move all inline OTel metrics to diagnostics_channel events

logaretm
and
claude
committed
refactor: consolidate all OTel metric classes into channel subscribers

logaretm
and
claude
committed
test: remove no-op channel publish tests

logaretm
and
claude
committed
refactor: use CHANNELS map consistently and tracingChannel API for subscriptions

logaretm
and
claude
committed
chore: remove dead types and interfaces from opentelemetry module

logaretm
and
claude
committed
refactor: deduplicate diagnostics_channel loading

logaretm
and
claude
committed
refactor: rename BatchTraceContext to BatchOperationContext

logaretm
and
claude
committed
chore: remove unused CONNECTION_WAIT_START event

logaretm
and
claude
committed
fix: restore wasReady guard on connection count decrement

logaretm
and
claude
committed
feat: export all channel names and event types for APM consumers

logaretm
and
claude
committed
refactor: convert pool wait time to TracingChannel

logaretm
and
claude
committed
fix: consistent serverPort typing across all event interfaces

logaretm
and
claude
committed
refactor: add getTracingChannel helper with auto-resolved context types

logaretm
and
claude
committed
refactor: stop exporting dc, use getTracingChannel and getChannel instead

logaretm
and
claude
committed
refactor: unify trace functions into single generic trace()

logaretm
and
claude
committed
refactor: store unsubscriber closures instead of handler references

logaretm
and
claude
committed
chore: delete noop-metrics.ts

logaretm
and
claude
committed
fix: deduplicate COMMAND_REPLY events and merge subscriber

logaretm
and
claude
committed
fix: reject tracing promise on pool acquire timeout

logaretm
and
claude
committed
chore: remove noop-meter.ts

logaretm
and
claude
committed
fix: sanitize COMMAND_REPLY args and catch pool trace promise

logaretm
and
claude
committed
fix: reject pending wait traces on pool destroy

logaretm
and
claude
committed
style: move const noop after imports in pool.ts

logaretm
and
claude
committed
fix: E2E test failures from refactor

logaretm
and
claude
committed
fix: record connection wait time when client is immediately available

logaretm
and
claude
committed
style: clean up comments, remove em dashes, be concise

logaretm
and
claude
committed
fix(perf): optimize channel acquisition
logaretm
committed
refactor: deduplicate command error reporting, use TracingChannel error event

logaretm
and
claude
committed
fix: filter redirection errors at call site, not in #recordError

logaretm
and
claude
committed
fix: use ctx.origin instead of ctx.internal for redirection deduplication

logaretm
and
claude
committed
fix: guard against disabled metrics in OTelMetrics constructor

logaretm
and
claude
committed
fix: treat MULTI as atomic operation, remove per-command tracing

logaretm
and
claude
committed

Commits on Apr 2, 2026

docs: clarify diagnostics tracing channel lifecycle
PavelPashov
committed