fix: fallthrough bug in transformDoubleReply#3213
Open
rhymincymon wants to merge 1 commit intoredis:masterfrom
Open
fix: fallthrough bug in transformDoubleReply#3213rhymincymon wants to merge 1 commit intoredis:masterfrom
rhymincymon wants to merge 1 commit intoredis:masterfrom
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inner
switchintransformDoubleReplyis missingbreakstatements, causing every case to fall through todefaultand overwriteretwithNumber(reply). This means'+inf'and'-inf'replies are never correctly converted toInfinityand-Infinity.Note
Medium Risk
Touches shared reply-parsing logic used across many commands; while the change is small, it alters how special double strings are converted and could affect downstream consumers that relied on the previous (buggy) behavior.
Overview
Fixes
transformDoubleReplyso RESP2 double string replies for+inf/-inf/nanno longer fall through to the default numeric conversion.Adds missing
breakstatements in the innerswitch, ensuringInfinity,-Infinity, andNaNare preserved instead of being overwritten byNumber(reply).Written by Cursor Bugbot for commit d4e4d92. This will update automatically on new commits. Configure here.