Fix layout issues in component-home-v2 from PR #369#370
Conversation
Fixes two layout issues introduced in PR #369: 1. Main element width constraint: Exclude .home-content from the nav-width calculation to prevent content from being squished on home pages - Updated main.css selector from `main:not(.labs)` to `main:not(.labs):not(.home-content)` 2. Overview heading layout: Move heading outside the .home-intro flex container and make it visually hidden to prevent inline display - Moved h2#home-overview before the .home-intro div - Added .visually-hidden class to hide heading while keeping it accessible Tested with Playwright to verify: - Main element has full width (1160px, not constrained) - Overview heading is visually hidden (height: 1px, not visible) - Intro paragraph displays on its own line Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
✅ Deploy Preview for docs-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR makes two targeted modifications to the homepage component styling and structure. First, a CSS selector is narrowed by adding an additional exclusion ( Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
The metadata--main div was being rendered even when empty for component-home-v2 pages, causing unwanted spacing below the h1. Wrapped the metadata div in an unless condition to exclude it completely for component-home-v2 role pages. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
All background tasks have already completed and their results were used in the previous response. The testing is done — no further action needed from those notifications. To summarize what was accomplished:
All results were already analyzed and verified. PR #370 is confirmed to fix both issues correctly for the Redpanda Connect and Redpanda Cloud home pages. |

Summary
Fixes two layout issues introduced in PR #369 that were affecting home pages using the component-home-v2 layout (like https://docs.redpanda.com/redpanda-cloud/home/):
<main class="home-content">wrapper was being constrained by thewidth: calc(100% - var(--nav-width))rule, causing content to be squishedChanges
src/css/main.css
main:not(.labs)tomain:not(.labs):not(.home-content)on line 36.home-contentclass from the nav-width constraintsrc/partials/component-home-v2.hbs
<h2 id="home-overview">element outside the.home-introflex container (lines 3-7).visually-hiddenclass to the heading to hide it visually while keeping it accessible for screen readers and ARIATesting
Verified fixes using Playwright:
Screenshot evidence included in testing.
🤖 Generated with Claude Code