Fix race condition in loadSession with shared session cache#386
Open
thesinakamali wants to merge 1 commit intorefraction-networking:masterfrom
Open
Fix race condition in loadSession with shared session cache#386thesinakamali wants to merge 1 commit intorefraction-networking:masterfrom
thesinakamali wants to merge 1 commit intorefraction-networking:masterfrom
Conversation
When multiple goroutines share a ClientSessionCache, loadSession() returns a *SessionState pointer that is shared across connections. Subsequent code (e.g. SessionTicketExtension.InitializeByUtls) mutates this session object, causing a data race. Fix by making a shallow copy of the SessionState immediately after retrieving it from the cache.
|
@thesinakamali man your PR pointed me into good direction when investigating why my server is failing in production. I spent over 60h in total looking for problem. THANK YOU! Live long and prosper 🖖 to maintainers: please merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple goroutines share a ClientSessionCache, loadSession() returns a *SessionState pointer that is shared across connections. Subsequent code (e.g. SessionTicketExtension.InitializeByUtls) mutates this session object, causing a data race. Fix by making a shallow copy of the SessionState immediately after retrieving it from the cache.