Allow reload on weapons with altered ammo type#1151
Closed
BoloVEVO wants to merge 3 commits intorehlds:masterfrom
Closed
Allow reload on weapons with altered ammo type#1151BoloVEVO wants to merge 3 commits intorehlds:masterfrom
BoloVEVO wants to merge 3 commits intorehlds:masterfrom
Conversation
…gnals Implement CBasePlayer::HandleSignals Hook
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Author
|
I will reopen this pr again I forgot I did the pr with the master branch instead of a separate branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
ReGameDLL already gives support via ReAPI to implement custom ammo types, making possible to change the ammo type of any weapon, the current checks of weapon reload is that the player needs to have the original ammo type of the weapon in order to reload, which lead into issues if the user wishes to alter the current ammo type.
Approach
It now checks with the current item's ammo type instead of a hardcoded ammo type.
If there's a particular reason why to check the reload function with a hardcoded ammo type instead of grabbing the current item's ammo type, please explain.