Skip to content

Enable session based access for database#765

Merged
0xTxbi merged 4 commits intomainfrom
joseph/rly-1804-enable-session-based-access-for-database
Mar 31, 2026
Merged

Enable session based access for database#765
0xTxbi merged 4 commits intomainfrom
joseph/rly-1804-enable-session-based-access-for-database

Conversation

@0xTxbi
Copy link
Copy Markdown
Member

@0xTxbi 0xTxbi commented Feb 26, 2026

No description provided.

@0xTxbi 0xTxbi requested a review from julien51 February 26, 2026 13:35
Copy link
Copy Markdown
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @fdmota can you check as well?

@0xTxbi did you run locally? that's a big upgrade and I want to make sure we're not misisng anything

@fdmota
Copy link
Copy Markdown
Collaborator

fdmota commented Mar 9, 2026

LGTM! @fdmota can you check as well?

@0xTxbi did you run locally? that's a big upgrade and I want to make sure we're not misisng anything

This code supports both authentication with password and token. If we merge this it won't break anything because the DATABASE_URL contains the password. After that, to enable authentication with token, I need to change the database config.

Copy link
Copy Markdown
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok LGTM then!

@0xTxbi let's merge at your earliest convenience and then @fdmota can change the env var?

@0xTxbi 0xTxbi merged commit 0f14a96 into main Mar 31, 2026
13 checks passed
@0xTxbi 0xTxbi deleted the joseph/rly-1804-enable-session-based-access-for-database branch March 31, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants