fix(flipt): rewrite license docs to use Replicated CLI commands#143
Draft
kriscoleman wants to merge 2 commits intomainfrom
Draft
fix(flipt): rewrite license docs to use Replicated CLI commands#143kriscoleman wants to merge 2 commits intomainfrom
kriscoleman wants to merge 2 commits intomainfrom
Conversation
The getting started docs referenced non-existent scripts (./scripts/setup-dev-license.sh, ./scripts/install.sh), Makefile targets (install-with-license, clean-license), and env var workflows (.replicated/license.env) that were never created. Replaced with the deterministic flow: create a customer, download the license file via `replicated customer download-license`, and pass it to helm via `--set-file replicated.license=license.yaml`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jmboby
previously approved these changes
Mar 30, 2026
Member
jmboby
left a comment
jmboby
left a comment
There was a problem hiding this comment.
Looks good, thanks for this @kriscoleman !
jmboby
reviewed
Mar 30, 2026
jmboby
reviewed
Mar 30, 2026
| replicated customer download-license \ | ||
| --app flipt \ | ||
| --customer "$CUSTOMER_NAME" \ | ||
| --output license.yaml |
Member
There was a problem hiding this comment.
No doubt you will find this too but it wants to use the customer id instead of name:
Error: find customer "dev-jwilson": get customer by name: customer "dev-jwilson" is ambiguous, please use customer ID
jmboby
reviewed
Mar 30, 2026
| --namespace flipt \ | ||
| --create-namespace \ | ||
| --set-file replicated.license=license.yaml \ | ||
| --wait --timeout 15m |
Member
There was a problem hiding this comment.
This worked as expected in my testing
Co-authored-by: James Wilson <14128934+jmboby@users.noreply.github.com>
kriscoleman
changed the title
kriscoleman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./scripts/setup-dev-license.sh,./scripts/install.sh), Makefile targets (install-with-license,clean-license), and env var workflows (.replicated/license.env) that were never createdreplicated customer create→replicated customer download-license→helm install --set-file replicated.license=license.yamlmake update-depsinstead of manual repo-add commandsTest plan
replicated customer create+replicated customer download-licenseflow works end-to-endhelm install --set-file replicated.license=license.yamlcorrectly passes the license to the Replicated SDK🤖 Generated with Claude Code