Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
unique-idvalues that are used directly in persistence filenames.Description
burp.util.StorageFileUtilswhich centralizes identifier sanitization (sanitizeIdentifierForFilename) and builds safe storage paths viainteractionsFile(File, String).StorageFileUtils.interactionsFile(...)inPollingService,BinTab, andBinServiceto eliminate path traversal risk when creating/reading/writinginteractions-{id}.json.BinTabClear All flow to perform persistence-file deletion on a background daemon thread (deletePersistenceFileAsync) and report results back onto the EDT withSwingUtilities.invokeLater, whiledeletePersistenceFilenow returns abooleanindicating success.Testing
mvn -q -DskipTests compile, which failed due to external dependency resolution (Maven Central returned HTTP 403 formaven-resources-plugin), so the code changes were not validated by a successful full build in this environment.Codex Task