feat(react-email): support custom export extension#2555
Open
hosmelq wants to merge 3 commits intoresend:canaryfrom
Open
feat(react-email): support custom export extension#2555hosmelq wants to merge 3 commits intoresend:canaryfrom
hosmelq wants to merge 3 commits intoresend:canaryfrom
Conversation
🦋 Changeset detectedLatest commit: 9bd8014 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
@hosmelq is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
hosmelq
force-pushed
the
support-custom-export-extension
branch
from
ecb743a to
be8cc28
Compare
hosmelq
changed the title
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/react-email/src/commands/export.ts">
<violation number="1" location="packages/react-email/src/commands/export.ts:121">
If the CLI receives a dot-prefixed extension (e.g., `--extension .html`), this ternary sets `extension` to `..html`, so exported filenames gain an extra dot (e.g., `example..html`). Please reuse the user-supplied dot when present so both dot-prefixed and bare extensions work.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
hosmelq
changed the title
gabrielmfern
force-pushed
the
canary
branch
4 times, most recently
from
7da803f to
e9af285
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
--extension/-eflag to the CLI export command, document the new option, and add a test.Related
Summary by cubic
Add a new --extension/-e flag to the export CLI to set a custom output file extension (e.g., blade.php). If omitted, it defaults to .txt with --plainText, otherwise .html; docs updated and tests added.