Skip to content

feat: improve skill tests#2956

Open
cpenned wants to merge 2 commits intocanaryfrom
feat/improve-skill-tests
Open

feat: improve skill tests#2956
cpenned wants to merge 2 commits intocanaryfrom
feat/improve-skill-tests

Conversation

@cpenned
Copy link
Contributor

@cpenned cpenned commented Feb 12, 2026


Summary by cubic

Clarifies the React Email skill to enforce correct Tailwind preset imports and required utility classes for reliable rendering. Adds a new test and broader regression checks to prevent past failures.

  • New Features

    • Added “Required Classes” table (Button needs box-border; borders require border-solid; single-side borders reset with border-none).
    • Enforced Tailwind preset import: use pixelBasedPreset from @react-email/components; do not import from @react-email/tailwind or /presets.
    • Added Test A15 for import source and expanded regression checks across scenarios, including pressure tests.
  • Migration

    • Import pixelBasedPreset from @react-email/components only.
    • Add box-border to all Buttons.
    • Always set border type; when using one-side borders, reset others with border-none.

Written for commit 00e0a3e. Summary will update on new commits.

@vercel
Copy link

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment Feb 12, 2026 7:13pm
react-email-demo Ready Ready Preview, Comment Feb 12, 2026 7:13pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2026

⚠️ No Changeset found

Latest commit: 00e0a3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant