Skip to content

feat(logs): add logs API support#162

Merged
drish merged 4 commits intomainfrom
feat/logs-api
Apr 2, 2026
Merged

feat(logs): add logs API support#162
drish merged 4 commits intomainfrom
feat/logs-api

Conversation

@drish
Copy link
Copy Markdown
Member

@drish drish commented Mar 31, 2026

Implements Resend::Logs.get and Resend::Logs.list endpoints.

drish added 2 commits March 31, 2026 10:14
Implements Resend::Logs.get and Resend::Logs.list endpoints.
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 5 files

Confidence score: 3/5

  • There is concrete merge risk from lib/resend.rb: new Resend::Logs.get/list operations were added without the required API key permission check configuration, which could lead to authorization/permission mismatches at runtime.
  • The spec/logs_spec.rb issues are mostly non-blocking quality concerns (should phrasing rule and nested key assertions using symbols instead of strings), but they reduce test clarity and may hide response-shape mismatches.
  • Given one high-severity, high-confidence SDK rule violation with user-impact potential, this looks like moderate risk rather than a safe low-risk merge.
  • Pay close attention to lib/resend.rb, spec/logs_spec.rb - missing permission-check wiring is the key risk, and test updates should align naming and nested key expectations.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="lib/resend.rb">

<violation number="1" location="lib/resend.rb:31">
P1: Custom agent: **API Key Permission Check SDK Methods**

Rule 1 (API Key Permission Check SDK Methods) is violated: this change introduces new Logs API operations (`Resend::Logs.get`/`list`) but does not include a confirmation/reminder to validate that production API keys have Logs read permissions, which can cause post-deploy authorization failures.</violation>
</file>

<file name="spec/logs_spec.rb">

<violation number="1" location="spec/logs_spec.rb:12">
P1: Custom agent: **No `should` in tests**

Test descriptions use `should`, which violates the test naming rule. Use direct declarative phrasing (e.g., `retrieves...`, `handles...`, `raises...`, `lists...`) instead.</violation>

<violation number="2" location="spec/logs_spec.rb:101">
P2: Use string keys for nested response objects in assertions (`["id"]`), not symbols.

(Based on your team's feedback about nested response items using string keys.) [FEEDBACK_USED]</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="examples/logs.rb">

<violation number="1" location="examples/logs.rb:27">
P2: Don't execute `list_paginated` by default while it still uses a placeholder `after` cursor.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="examples/logs.rb">

<violation number="1" location="examples/logs.rb:27">
P1: Custom agent: **API Key Permission Check SDK Methods**

This PR introduces new Resend SDK log operations (`Logs.get`/`Logs.list`) but does not include confirmation that production API keys have the required permissions. Please explicitly confirm key scope readiness to prevent permission-related failures after deployment.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@drish drish merged commit eadff5a into main Apr 2, 2026
12 checks passed
@drish drish deleted the feat/logs-api branch April 2, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants