Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
.github/workflows/release.yml
Outdated
| with: | ||
| upload_url: ${{ steps.create_release.outputs.upload_url }} # This pulls from the CREATE RELEASE step above, referencing it's ID to get its outputs object, which include a `upload_url`. See this blog post for more info: https://jasonet.co/posts/new-features-of-github-actions/#passing-data-to-future-steps | ||
| asset_path: ./dist/taskrunner-linux.tar.gz | ||
| upload_url: ${{ steps.create_release.outputs.upload_url }} | ||
| asset_path: ./artifacts/taskrunner-linux-x86_64/taskrunner-linux.tar.gz |
There was a problem hiding this comment.
The build matrix uploads artifacts with path: dist/*.tar.gz, which preserves the dist/ directory inside the artifact. After the release job downloads all artifacts, the files will be at artifacts/taskrunner-linux-x86_64/dist/... (and similarly for ARM64). The upload step currently points to ./artifacts/taskrunner-linux-x86_64/taskrunner-linux.tar.gz, which does not exist, so the first upload-release-asset action will fail and the release will never publish assets for either architecture. Point the asset path to the actual dist/*.tar.gz file inside the downloaded artifact directory or flatten the artifact during upload.
Useful? React with 👍 / 👎.
2 participants
No description provided.