refactor: move transport TLS config into inner state#99
Merged
Conversation
Domain names were lost during DNS resolution in lookup(), causing TlsConnection::connect to see only IP addresses and omit the SNI extension. Servers requiring SNI rejected with handshake_failure (alert 40). Now captures the original domain before resolution and passes it as sni_hostname through TlsConfig. Also wires TlsConfig into connect() to support CA certs, client certs, and explicit SNI override. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #98 from @wokalski.
This keeps Wojtek Czekalskis TLS SNI preservation fix, but narrows the TransportLayer API shape by storing outbound TLS config inside TransportLayerInner instead of exposing it as a new public field on TransportLayer.
Changes in this follow-up:
This PR is intended as a small source-only refinement on top of #98, while preserving the original authors fix and attribution.