Skip to content

fix: recorder duration calculation #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenjinti merged 1 commit into from
Feb 25, 2026
+3 −4
Merged

fix: recorder duration calculation #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/media/recorder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,14 @@ impl Recorder {
_ => return Ok(()),
};
let decoder_type = CodecType::try_from(frame.payload_type.unwrap_or(0))?;
let mut decoder_samplerate = self.sample_rate;
let decoder_clockrate = decoder_type.clock_rate();

if decoder_type != self.codec {
let decoder = self
.decoders
.entry((leg, decoder_type.payload_type()))
.or_insert_with(|| create_decoder(decoder_type));
let pcm = decoder.decode(&encoded);
decoder_samplerate = decoder.sample_rate();
let resampler = self
.resamplers
.entry((leg, decoder_type.payload_type()))
Expand Down Expand Up @@ -197,7 +196,7 @@ impl Recorder {
.rtp_timestamp
.wrapping_sub(self.base_timestamp_a.unwrap());
let scaled_relative =
(relative as u64 * self.sample_rate as u64 / decoder_samplerate as u64) as u32;
(relative as u64 * self.sample_rate as u64 / decoder_clockrate as u64) as u32;
self.start_offset_a.wrapping_add(scaled_relative)
}
Leg::B => {
Expand All @@ -215,7 +214,7 @@ impl Recorder {
.rtp_timestamp
.wrapping_sub(self.base_timestamp_b.unwrap());
let scaled_relative =
(relative as u64 * self.sample_rate as u64 / decoder_samplerate as u64) as u32;
(relative as u64 * self.sample_rate as u64 / decoder_clockrate as u64) as u32;
self.start_offset_b.wrapping_add(scaled_relative)
}
};
Expand Down