Ensure leading slash if path component is a directory#75
Open
hrkfdn wants to merge 1 commit intoreyk:masterfrom
Open
Ensure leading slash if path component is a directory#75hrkfdn wants to merge 1 commit intoreyk:masterfrom
hrkfdn wants to merge 1 commit intoreyk:masterfrom
Conversation
This fixes Werkzeug-based and possibly other applications using
PATH_INFO.
CGI RFC3875[1] and PEP3333 state that PATH_INFO can be empty ("") or "/"
for application root paths, but some applications (Werkzeug/Flask)
except it to be "/". This diff ensures that.
Followup discussions:
reyk#71
pallets/werkzeug#1240
[1]: https://tools.ietf.org/html/rfc3875#section-4.1.5
[2]: https://www.python.org/dev/peps/pep-3333/#environ-variables
|
@reyk: Have you seen this PR? |
|
There's no point in creating PRs on GitHub. This repository is outdated and no longer maintained by Reyk. @hrkfdn You should mail a diff to tech@openbsd.org if you want a review! I'd really love to see this be implemented |
Contributor
Author
|
Hey! I did bring it up on openbsd-tech. I was told to approach the Flask maintainers, but they disagreed. At that point I was too frustrated to push further. |
|
Ahh, damnit. Perhaps try your luck now with a little ping in the mailing list again? |
Contributor
Author
Appreciate the encouragement ❤️ But I don't use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Werkzeug-based and possibly other applications using
PATH_INFO.CGI RFC3875 and PEP3333 state that
PATH_INFOcan be empty ("") or "/" for application root paths, but some applications (Werkzeug/Flask) expect it to be "/". This diff makes sure that this is the case. Werkzeug maintainers consider this to be an implementation mistake on httpd's side.Followup discussions:
#71
pallets/werkzeug#1240
Fixes #71.