Implement futures::io::AsyncRead and AsyncWrite#7
Draft
olivia-fl wants to merge 3 commits intoreyk:masterfrom
Draft
Implement futures::io::AsyncRead and AsyncWrite#7olivia-fl wants to merge 3 commits intoreyk:masterfrom
olivia-fl wants to merge 3 commits intoreyk:masterfrom
Conversation
olivia-fl
changed the title
olivia-fl
force-pushed
the
impl-futures-io
branch
from
364b893 to
dc3da84
Compare
olivia-fl
force-pushed
the
impl-futures-io
branch
from
dc3da84 to
ef08e71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #6, so don't merge it until that #6 is merged.
tokio::ioandfutures::iohave completely separateAsyncReadandAsyncWritetraits. There is a compatibility layer between the two, but it's clunky. We might as well implement both traits. This results in a bit of code duplication, but it's not too bad, and simplifies usingtokio-libtlswithfutures::iofor users.