feat: integrate profile completeness check into captcha verification#9
Open
rezhajulio wants to merge 2 commits intomainfrom
Open
feat: integrate profile completeness check into captcha verification#9rezhajulio wants to merge 2 commits intomainfrom
rezhajulio wants to merge 2 commits intomainfrom
Conversation
- Update captcha welcome message to inform users about profile requirements - Add profile completeness check (photo + username) in captcha callback handler - Reject verification with alert if profile is incomplete, keeping timeout active - Fix double query.answer() bug — each code path now answers exactly once - Add CAPTCHA_INCOMPLETE_PROFILE_MESSAGE constant for rejection alert - Update and add tests for new captcha+profile flow (553 tests, 99% coverage)
- Add parse guard for malformed callback data (ValueError/IndexError) - Move timeout job cancellation after successful unrestrict + DB cleanup - Wrap DB finalization in try/except to prevent unanswered callbacks - Replace AsyncMock with ProfileCheckResult dataclass in all test mocks - Add tests for malformed callback data and unrestrict failure preserving timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combines captcha verification with a mandatory profile completeness check (photo + username) before unrestricting new members.
Changes
Captcha + Profile Check Integration
Handler Hardening
Test Improvements
AsyncMock(is_complete=...)with realProfileCheckResultdataclass in all mocksFlow
Tests: 555 passed, ~99.9% coverage