Open
Conversation
added 2 commits
April 6, 2026 22:32
…lly mean wildcard, it means unscoped. Region keys should still only be forwaded if they're whitelisted. UI changes pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the region handling in pyMC Repeater.
Previously in pyMC Repeater, the unscoped region, poorly named by Meshcore as "" was interperitred as a "global" or "wildcard" handling. An easy mistake to make, the actual meaning of "" is "unscoped" - that is that no region is defined to the packets, and "" is what is used to permit/block unscoped traffic. Is essenence the "" is actually representative of the "unscoped" region - confusing, hey?
Regions themselves are subject to a separate handler - no wildcard concept exists in the mainstream firmware, and as such regions need to be configured on a case-by-case as configured in the repeater. If the region is not configured, the repeaters behaviour is to drop traffic with a scope set that the repeater doesn't know about.
This PR removes the "Global" concept from pyMC and replaces it with two separate concepts
Pending: UI changes to support the changes. If this PR is merged right now, clicking the Allow/Deny in the UI will break the config page for Regions/Keys.
The PR has been setup to introduce a new variable "unscoped_flood_allow" to replace the "global_flood_allow" variable previously used, while maintaining backward compatability with the config files if "global_flood_allow" has been configured and the new "unscoped_flood_allow" is missing.
Question: What is the "Keys" section in regions/keys used for? It seems a bit misleading as to what it's meant to be in the UI. Can we remove the keys concept entirely and just leave it as Regions, as that would match what is in the upstream firmware?