fix: allow TRACE packets to reach engine for MQTT/LetsMesh publishing#171
Open
dmduran12 wants to merge 1 commit intorightup:devfrom
Open
fix: allow TRACE packets to reach engine for MQTT/LetsMesh publishing#171dmduran12 wants to merge 1 commit intorightup:devfrom
dmduran12 wants to merge 1 commit intorightup:devfrom
Conversation
TRACE packets were short-circuited by processed_by_injection=True (fa0261d), preventing them from reaching the engine's storage/MQTT/LetsMesh publishing path. This meant trace responses with per-hop SNR data were consumed locally by the trace helper but never published to telemetry platforms. Fix: replace processed_by_injection with mark_do_not_retransmit(), matching the existing pattern used by ControlHandler. The trace helper still processes the packet for local terminal display (RTT/SNR). The engine records it to storage and publishes to MQTT/LetsMesh, but does not re-broadcast over RF. Co-Authored-By: Oz <oz-agent@warp.dev>
dmduran12
force-pushed
the
fix/trace-mqtt-publish
branch
from
8eeea68 to
5949ae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TRACE packets were silently dropped from the MQTT/LetsMesh publishing path since commit fa0261d (Dec 1, 2025). The
processed_by_injection = Trueflag inpacket_router.pyprevented trace responses from reaching the engine's storage and telemetry publishing.This meant:
main(which doesn't have packet_router.py) still publish traces normallyFix
Replace
processed_by_injection = Truewithpacket.mark_do_not_retransmit(), matching the existing pattern used byControlHandler(line 180).Before: trace helper processes →
processed_by_injection = True→ engine skipped → no MQTTAfter: trace helper processes →
mark_do_not_retransmit()→ engine records + publishes to MQTT/LetsMesh → RF retransmit blockedWhat stays the same
1 file changed, 4 insertions, 3 deletions
Co-Authored-By: Oz oz-agent@warp.dev