feat!: unify code with package:web_socket#435
Open
mertalev wants to merge 3 commits intorikulo:masterfrom
Open
feat!: unify code with package:web_socket#435mertalev wants to merge 3 commits intorikulo:masterfrom
mertalev wants to merge 3 commits intorikulo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates platform-specific websocket code to the modern
package:web_socketWebSocketinterface, which has implementations in cupertino_http, ok_http and can be extended with custom implementations. This means users can use and configure their own HTTP client without dedicated adapters in this library. As part of this, it replacessetHttpClientAdapterwithsetWebSocketConnectorand removesHttpClientAdapter. This is a breaking change, but one I believe is worthwhile considering the consolidation and extensibility it offers.I've added tests and done some testing of this branch in my app with cupertino_http and ok_http to confirm it works as expected.