feat: add analyst agent support for canvas dashboard#8669
Merged
AdityaHegde merged 15 commits intomainfrom Feb 9, 2026
Merged
Conversation
AdityaHegde
changed the title
begelundmuller
requested changes
Jan 30, 2026
djbarnwal
approved these changes
Feb 3, 2026
Member
djbarnwal
left a comment
djbarnwal
left a comment
There was a problem hiding this comment.
Looks good, works well.
In general I would suggest that we can tighten up the types in some places
Nice to have features (can do as follow up) -
- When there's just 1 component in a row, mention label at
Component at row ninstead ofComponent at row n column 1 - Highlighting a component from the picker in the chat should highlight the component by adding a temporary ring
Comment on lines
+228
to
+238
| if (CHART_CONFIG[renderer]?.provider) { | ||
| const providerClass: ChartMetadataConfig["provider"] = | ||
| CHART_CONFIG[renderer].provider; | ||
| const provider = new providerClass( | ||
| readable(componentSpec?.rendererProperties as any), | ||
| ); | ||
|
|
||
| const fields = getFieldsForSpec( | ||
| componentSpec?.rendererProperties as any, | ||
| metricsViewSpec ?? {}, | ||
| ); |
Member
There was a problem hiding this comment.
Can we add stricter typing here?
Comment on lines
+64
to
+71
| const componentSpec = meta.componentSpecs[ctx.canvasComponent!]; | ||
| return getLabelForComponent( | ||
| ctx.canvasComponent!, | ||
| componentSpec, | ||
| meta.metricsViewSpecs[ | ||
| (componentSpec?.rendererProperties?.metrics_view as | ||
| | string | ||
| | undefined) ?? "" |
Member
There was a problem hiding this comment.
I see a few lint warnings in this file.
Contributor
begelundmuller
left a comment
begelundmuller
left a comment
There was a problem hiding this comment.
Backend changes look good now
begelundmuller
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for analyst agent for canvas dashboards.
Closes APP-674
Checklist: