Closed
Conversation
This reverts commit 93bfc90.
Move form creation out of AddDataFormManager into a dedicated createConnectorForm() factory function in FormValidation.ts. The manager now accepts form stores as parameters instead of creating them, making it a pure orchestration layer that handles step flow, submission routing, and validation coordination. This separation allows form creation to be reused and tested independently of the orchestration logic.
Remove properties and filteredParamsProperties from AddDataFormManager as they were computed but never used - computeYamlPreview retrieves schema fields directly when needed. This completes the simplification of AddDataFormManager to a thin orchestration layer that derives all behavior from JSON schemas.
When S3 sources are rewritten to DuckDB, the model YAML was incorrectly using the original connector instance name (s3) instead of duckdb. This caused the backend to expect a 'path' property but receive 'sql', resulting in "missing property \`path\`" errors. Now when a connector is rewritten to DuckDB, the YAML connector field uses duckdb, while credential access is maintained via create_secrets_from_connectors.
When S3 sources are rewritten to DuckDB, the model YAML was incorrectly using the original connector instance name (s3) instead of duckdb. This caused the backend to expect a 'path' property but receive 'sql', resulting in "missing property \`path\`" errors. Now when a connector is rewritten to DuckDB, the YAML connector field uses duckdb, while credential access is maintained via create_secrets_from_connectors.
Enable users to choose between rill-managed infrastructure and self-hosted ClickHouse Cloud connections, mirroring the same pattern used in the standard ClickHouse connector.
…extracted variables - Remove duplicate JSDoc comment on computeYamlPreview - Extract explanatory variables in getPrimaryButtonLabel (isOnConnectorStep, isOnSourceOrExplorerStep) - Add comments clarifying each button label branch - Extract three key variables in makeOnUpdate for clarity: - isOnSourceOrExplorerStep: reduces conditional duplication - isOnConnectorStep: makes connector step checks explicit - isPublicAuth: clarifies authentication method checks - Extract submitConnectorStepAndAdvance private method to reduce nesting - Add section comments throughout makeOnUpdate explaining validation flow and submission logic
* identityhash * decoded from hex first * Update types.d.ts * Review --------- Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
…lldata/rill into feat/play-clickhouse-template
Contributor
Author
|
re-opening in new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can possibly open the door for other templating connectors/sources.
requested by Mike: https://rilldata.slack.com/archives/C07710F6932/p1769619124383569
Checklist: