lib: sbi: Fix behavior on platform without HART protection#410
Closed
michalsimek wants to merge 1 commit intoriscv-software-src:masterfrom
Closed
lib: sbi: Fix behavior on platform without HART protection#410michalsimek wants to merge 1 commit intoriscv-software-src:masterfrom
michalsimek wants to merge 1 commit intoriscv-software-src:masterfrom
Conversation
The commit 42139bb ("lib: sbi: Replace sbi_hart_pmp_xyz() and sbi_hart_map/unmap_addr()") changed logic by calling sbi_hart_protection_configure(). But when protection doesn't exist the function is returning SBI_EINVAL. But on systems without protection this is correct configuration that's why do not hang when system don't have any HART protection. Signed-off-by: Michal Simek <michal.simek@amd.com>
|
We have mailing list based patch review so it would be great if you can send these patchs to OpenSBI mailing list. You need to join OpenSBI mailing list using following link Make sure you use "git send-email" to send the patches. Thanks for your contribution to OpenSBI project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit 42139bb ("lib: sbi: Replace sbi_hart_pmp_xyz() and sbi_hart_map/unmap_addr()") changed logic by calling sbi_hart_protection_configure(). But when protection doesn't exist the function is returning SBI_EINVAL.
But on systems without protection this is correct configuration that's why do not hang when system don't have any HART protection.
I only tested cold boot but likely that issue is also related to warm case that's why I have fixed that too.
Another solution could be obviously also by fixing by returning 0 in case that no protection is available.