GDS generation metadata correction and execution permissions change#10
Open
lfzuniga wants to merge 1 commit intormanohar:masterfrom
Open
GDS generation metadata correction and execution permissions change#10lfzuniga wants to merge 1 commit intormanohar:masterfrom
lfzuniga wants to merge 1 commit intormanohar:masterfrom
Conversation
…scripts to be executable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem 1: The GDS files generated from the rect2gds.py scripts would generate GDS with overhead metadata. This metadata leads to commercial tools believing there is an additional cell named "$$$CONTEXT_INFO$$$" which later leads to problems when automating the import of GDS into layout editors (ie, only ~25% of a whole cell library would be imported because the tools get confused by the metadata).
Fix: set with_metadata=False when generating GDS.
Problem 2: rect2gds.py, gds2rect.py and gds2rect.sh scripts could not be run even though they were installed with the act scripts flow.
Fix: changed executable permissions so when they are installed they can be run just like other scripts in the repo (like for example mag2rect.py).