chore(ts): export types CameraBoundsWithPadding, OnPressEvent#4120
Open
mariusud wants to merge 1 commit intornmapbox:mainfrom
Open
chore(ts): export types CameraBoundsWithPadding, OnPressEvent#4120mariusud wants to merge 1 commit intornmapbox:mainfrom
mariusud wants to merge 1 commit intornmapbox:mainfrom
Conversation
Contributor
|
@mariusud thanks much for the PR, can you please write a short summary on why do you need those types, |
Contributor
Author
@mfazekas we were previously deep-importing these types, but after recent changes they’re no longer exposed. CameraBoundsWithPadding is used for setting camera-bounds with an added padding, and OnPressEvent is used to properly type some onPress handlers |
|
I've been running into a similar situation, exposing the types would be nice 🙂. I'd like to avoid needing to deeply import like this: import type { OnPressEvent } from '@rnmapbox/maps/lib/typescript/src/types/OnPressEvent'
const onPress = React.useCallback((event: OnPressEvent) => {
...
}, [])
<Mapbox.ShapeSource onPress={onPress}>
....
</Mapbox.ShapeSource> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)