fix: address selection in Broxbourne Council

[teofanis]

The addition <select> elements shown above leak into our lookup and cause Cannot locate option with value ... errors when we try to select the UPRN. This change makes the selector target the Choose address drop-down explicitly.

Summary by CodeRabbit

• Bug Fixes
  • Improved address selection reliability for Broxbourne Council lookups, reducing the risk of selecting incorrect addresses during postcode searches.
  • Enhanced postcode input handling to ensure proper data entry when searching for collection details.

[coderabbitai]

📝 Walkthrough

Walkthrough

Updates the BroxbourneCouncil web scraping module to use a more specific XPath for address selection and adds explicit clearing of the postcode input field before entering a new value, improving robustness of the address lookup flow.

Changes

Cohort / File(s)	Summary
Council Module Address Selection Fix uk_bin_collection/uk_bin_collection/councils/BroxbourneCouncil.py	Replaces address selection locator with a more specific XPath targeting the select element following the "Choose address" label. Adds explicit clear() call before postcode input to ensure field is empty before typing new values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Fix WestOxfordshireDistrictCouncil #1726 — Adjusts Selenium locators for address selection in council-specific modules with similar selector refinements.

Suggested reviewers

• dp247

Poem

🐰 A hop and a click through Broxbourne's way,
XPaths refined, selectors at play,
Clear fields and addresses, now in their place,
No more confusion in form-filling's race!
With precision we bound, through the bins we collect,
A scraper so sturdy, what do we expect?

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: address selection in Broxbourne Council' directly and clearly describes the main change: fixing address selection functionality for Broxbourne Council, which aligns perfectly with the PR's objective of resolving address selection issues.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.67%. Comparing base (f6cbad7) to head (3db89c8).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1873   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files           9        9           
  Lines        1141     1141           
=======================================
  Hits          989      989           
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@uk_bin_collection/uk_bin_collection/councils/BroxbourneCouncil.py`:
- Around line 68-76: The code waits only for the <select> element before calling
Select(...).select_by_value(user_uprn), which can fail if options load
asynchronously; update BroxbourneCouncil.py to first wait for the option with
the desired UPRN to appear (e.g., use WebDriverWait +
EC.presence_of_element_located with an XPath like
"//label[normalize-space()='Choose
address']/following::select[1]/option[`@value`='{user_uprn}']"), then call
Select(address_select).select_by_value(user_uprn) so selection only occurs after
the option is present.

---

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f6cbad7 and 3db89c8.

📒 Files selected for processing (1)

• uk_bin_collection/uk_bin_collection/councils/BroxbourneCouncil.py

[teofanis]

Can we merge this?

[robbrad]

Will be part of March release

[robbrad]

Adding to March release