Skip to content

[DEP-289] Propagate property options to FE app#2058

Closed
dkosowski87 wants to merge 7 commits intomainfrom
cursor-damian/DEP-289-property-extraction-area-size-4b3d
Closed

[DEP-289] Propagate property options to FE app#2058
dkosowski87 wants to merge 7 commits intomainfrom
cursor-damian/DEP-289-property-extraction-area-size-4b3d

Conversation

@dkosowski87
Copy link
Copy Markdown
Contributor

@dkosowski87 dkosowski87 commented Mar 1, 2026

Summary

Property information about the possible options was not propagated through POST /workflows/blocks/describe. Therefore the frontend was not providing usable values for select boxes for operations like DetectionsPropertyExtract, ExtractImageProperty, etc. Instead it was falling back to a static description in the roboflow repo. This PR provides a change to operations introspection to resolve this issue.

Frontend PR - https://github.com/roboflow/roboflow/pull/10655

Initial Linear Issue: DEP-289

Changes

  • Included property_name_options in the OperationDescription and ExternalOperationDescription, this field is being populated whenever an OperationDefinition contains a property_name that is defined as a reference '$ref': '#/$defs/DetectionsProperty' and that reference resolves into an Enum
  • Added missing area_px and area_converted were added to detection property extraction to enable their use in filters and expressions.

Checklist

  • test_introspection_operations.py - test for the introduced mechanism
  • test_workflow_schema_detections_property.py - double checking if the options value are provided in the shcema for validation
  • tested locally with a setup with the app from https://github.com/roboflow/roboflow running against a local server

@cursor
Copy link
Copy Markdown

cursor Bot commented Mar 1, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 1, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dkosowski87
❌ cursoragent
You have signed the CLA already but the status is still pending? Let us recheck it.

@dkosowski87 dkosowski87 force-pushed the cursor-damian/DEP-289-property-extraction-area-size-4b3d branch from 0ac6534 to 9c67ef0 Compare March 10, 2026 11:57
@dkosowski87 dkosowski87 force-pushed the cursor-damian/DEP-289-property-extraction-area-size-4b3d branch from 9c67ef0 to 5066dc0 Compare March 19, 2026 11:30
cursoragent and others added 3 commits March 19, 2026 12:56
Co-authored-by: Damian Kosowski <dkosowski87@users.noreply.github.com>
…onDescription

This update introduces a new optional field, property_name_options, to both OperationDescription and ExternalOperationDescription classes. This field provides a list of possible property names for operations extracting property values from data. Additionally, new utility functions have been added to resolve property name options from operation schemas. Tests have been included to ensure the correct inclusion of area fields in the DetectionsProperty enum.
…escriptions

This change improves the clarity of the code by introducing a variable for operation type definitions, enhancing readability and maintainability. The refactoring does not alter the functionality of the method.
@dkosowski87 dkosowski87 force-pushed the cursor-damian/DEP-289-property-extraction-area-size-4b3d branch from 96ed39e to 3e2ab48 Compare March 19, 2026 11:56
@dkosowski87 dkosowski87 marked this pull request as ready for review March 19, 2026 12:17
@dkosowski87 dkosowski87 changed the title Property extraction area size [DEP-289] Propagate property options to FE app Mar 19, 2026
@dkosowski87 dkosowski87 enabled auto-merge (squash) March 20, 2026 09:31
@dkosowski87 dkosowski87 disabled auto-merge March 20, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants