[DEP-289] Propagate property options to FE app#2058
Closed
dkosowski87 wants to merge 7 commits intomainfrom
Closed
[DEP-289] Propagate property options to FE app#2058dkosowski87 wants to merge 7 commits intomainfrom
dkosowski87 wants to merge 7 commits intomainfrom
Conversation
|
Cursor Agent can help with this pull request. Just |
|
|
0ac6534 to
9c67ef0
Compare
9c67ef0 to
5066dc0
Compare
Co-authored-by: Damian Kosowski <dkosowski87@users.noreply.github.com>
…onDescription This update introduces a new optional field, property_name_options, to both OperationDescription and ExternalOperationDescription classes. This field provides a list of possible property names for operations extracting property values from data. Additionally, new utility functions have been added to resolve property name options from operation schemas. Tests have been included to ensure the correct inclusion of area fields in the DetectionsProperty enum.
…escriptions This change improves the clarity of the code by introducing a variable for operation type definitions, enhancing readability and maintainability. The refactoring does not alter the functionality of the method.
96ed39e to
3e2ab48
Compare
PawelPeczek-Roboflow
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Property information about the possible options was not propagated through
POST /workflows/blocks/describe. Therefore the frontend was not providing usable values for select boxes for operations likeDetectionsPropertyExtract,ExtractImageProperty, etc. Instead it was falling back to a static description in theroboflowrepo. This PR provides a change to operations introspection to resolve this issue.Frontend PR - https://github.com/roboflow/roboflow/pull/10655
Initial Linear Issue: DEP-289
Changes
property_name_optionsin theOperationDescriptionandExternalOperationDescription, this field is being populated whenever anOperationDefinitioncontains aproperty_namethat is defined as a reference'$ref': '#/$defs/DetectionsProperty'and that reference resolves into anEnumarea_pxandarea_convertedwere added to detection property extraction to enable their use in filters and expressions.Checklist
test_introspection_operations.py- test for the introduced mechanismtest_workflow_schema_detections_property.py- double checking if the options value are provided in the shcema for validationappfrom https://github.com/roboflow/roboflow running against a local server