Skip to content

Conversation

@Erol444
Copy link
Contributor

@Erol444 Erol444 commented Jan 24, 2026

Supports both from inference and from RF hosted server (dict)

Description

Created Detections.from_sam3() function that accepts resultss form inference library (Sam3SegmentationResponse) or dict results from serverless.roboflow.com/sam3/concept_segment endpoint.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)

Motivation and Context

To better support SAM3 result visualziation by SV

Changes Made

  • added from_sam3()

Testing

  • I have tested this code locally
  • I have added unit tests that prove my fix is effective or that my feature works
  • All new and existing tests pass

…th from `inference` and from RF hosted server (dict)
@Erol444 Erol444 requested a review from SkalskiP as a code owner January 24, 2026 15:08
@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 7.14286% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 59%. Comparing base (ac379e4) to head (fdb340e).
⚠️ Report is 8 commits behind head on develop.

❌ Your patch check has failed because the patch coverage (7%) is below the target coverage (95%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (59%) is below the target coverage (95%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2103   +/-   ##
=======================================
- Coverage       59%     59%   -0%     
=======================================
  Files           61      61           
  Lines         7076    7117   +41     
=======================================
+ Hits          4188    4190    +2     
- Misses        2888    2927   +39     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants