Support line continuation#1667
Open
luis-j-soares wants to merge 7 commits intorokucommunity:masterfrom
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
Will we need to update the formatter as well? |
Collaborator
Author
@markwpearce I would say so. I can open an issue and work on it once this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A future OS release will introduce automatic line continuation in BrightScript, allowing expressions and function call arguments to span multiple lines after binary operators (
+,-,*,/,\,mod,^,and,or, and relational operators).This PR adds parser support for that syntax behind an
allowLineContinuationflag.Behaviour
.bsfiles (BrighterScript mode).brsfiles via the newallowLineContinuation: trueconfig option (or--allow-line-continuationon the CLI)allowBrighterScriptInBrightScriptis set, since that already forces BrighterScript modeExamples
Arithmetic operators
Boolean operators
Relational operators
Chained across multiple lines
Function call arguments split across lines
Inline objects as arguments (supported since BrightScript's inception — unaffected by this flag)