Skip to content

Revert "[format] Use AlignFunctionDeclarations from clang-format 20.1.0"#21629

Merged
hahnjo merged 1 commit intoroot-project:masterfrom
hahnjo:revert-format
Mar 18, 2026
Merged

Revert "[format] Use AlignFunctionDeclarations from clang-format 20.1.0"#21629
hahnjo merged 1 commit intoroot-project:masterfrom
hahnjo:revert-format

Conversation

@hahnjo
Copy link
Member

@hahnjo hahnjo commented Mar 18, 2026

This reverts commit ffe6e24 from PR #19753.

@hahnjo hahnjo requested review from dpiparo and pcanal March 18, 2026 07:37
@hahnjo hahnjo self-assigned this Mar 18, 2026
@hahnjo hahnjo added pr:emergency🚨 This PR is fixing breakage, it's urgent and may overtake others skip ci Skip the full builds on the actions runners labels Mar 18, 2026
@github-actions
Copy link

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 462bf43.

Copy link
Contributor

@silverweed silverweed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of the previous formatting, but at this point I don't know who has the "authority" to dictate these changes, as they are basically arbitrary...

@dpiparo
Copy link
Member

dpiparo commented Mar 18, 2026

We have a major release coming, and a new series coming in some 30 months: is an agreement about formatting achievable?

@hahnjo hahnjo merged commit 8bfc036 into root-project:master Mar 18, 2026
14 checks passed
@hahnjo hahnjo deleted the revert-format branch March 18, 2026 08:36
@pcanal
Copy link
Member

pcanal commented Mar 18, 2026

See #19753 (comment)

@pcanal pcanal mentioned this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:emergency🚨 This PR is fixing breakage, it's urgent and may overtake others skip ci Skip the full builds on the actions runners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants