[tmva] Retire TH1::AddDirectory use in TMVA.#21646
Open
hageboeck wants to merge 1 commit intoroot-project:masterfrom
Open
[tmva] Retire TH1::AddDirectory use in TMVA.#21646hageboeck wants to merge 1 commit intoroot-project:masterfrom
hageboeck wants to merge 1 commit intoroot-project:masterfrom
Conversation
Replace uses of TH1::AddDirectory by TDirectory::TContext. It is thread-local and uses the RAII idiom, so state changes cannot inadvertently leak out of TMVA functions.
3 tasks
Test Results 22 files 22 suites 3d 6h 14m 25s ⏱️ For more details on these failures, see this check. Results for commit 3a29d35. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace uses of
TH1::AddDirectory()byTDirectory::TContext. It is thread-local and uses the RAII idiom, so state changes cannot inadvertently leak out of TMVA functions.