Skip to content

Make TTree::Draw() independent of histogram auto registration, suppress a warning #21648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hageboeck wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make TTree::Draw() independent of histogram auto registration, suppress a warning #21648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
129cf15
[core] Disable the TDirectory::Append warning when using the same obj…
hageboeck Mar 16, 2026
ce4eefd
[treeplayer] Make TTree::Draw independent of histogram registration.
hageboeck Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/base/src/TDirectory.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,10 @@ void TDirectory::Append(TObject *obj, Bool_t replace /* = kFALSE */)
if (replace && obj->GetName() && obj->GetName()[0]) {
TObject *old;
while (nullptr != (old = GetList()->FindObject(obj->GetName()))) {
Warning("Append","Replacing existing %s: %s (Potential memory leak).",
obj->IsA()->GetName(),obj->GetName());
if (obj != old) {
Warning("Append", "Replacing existing %s: %s (Potential memory leak).", obj->IsA()->GetName(),
obj->GetName());
}
ROOT::DirAutoAdd_t func = old->IsA()->GetDirectoryAutoAdd();
if (func) {
func(old,nullptr);
Expand Down
6 changes: 6 additions & 0 deletions tree/treeplayer/src/TSelectorDraw.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,7 @@ void TSelectorDraw::Begin(TTree *tree)
} else {
hist = new TH1D(hname, htitle.Data(), fNbins[0], fVmin[0], fVmax[0]);
}
hist->SetDirectory(gDirectory);
Copy link
Member

@pcanal pcanal Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this is not 'strictly' equivalent to the behavior of AddDirectoryStatus for histograms:

   if (TH1::AddDirectoryStatus()) {
      fDirectory = gDirectory;
      if (fDirectory) {
         fFunctions->UseRWLock();
         fDirectory->Append(this,kTRUE);
      }
   }

I.e. in the switch we 'lose' the part that make the histogram's list of function thread safe.

hist->SetLineColor(fTree->GetLineColor());
hist->SetLineWidth(fTree->GetLineWidth());
hist->SetLineStyle(fTree->GetLineStyle());
Expand Down Expand Up @@ -661,6 +662,7 @@ void TSelectorDraw::Begin(TTree *tree)
} else {
hp = new TProfile(hname, htitle.Data(), fNbins[1], fVmin[1], fVmax[1], "");
}
hp->SetDirectory(gDirectory);
if (!hkeep) {
hp->SetBit(kCanDelete);
if (!opt.Contains("goff")) hp->SetDirectory(nullptr);
Expand Down Expand Up @@ -689,6 +691,7 @@ void TSelectorDraw::Begin(TTree *tree)
} else {
h2 = new TH2D(hname, htitle.Data(), fNbins[1], fVmin[1], fVmax[1], fNbins[0], fVmin[0], fVmax[0]);
}
h2->SetDirectory(gDirectory);
h2->SetLineColor(fTree->GetLineColor());
h2->SetLineWidth(fTree->GetLineWidth());
h2->SetLineStyle(fTree->GetLineStyle());
Expand Down Expand Up @@ -803,6 +806,7 @@ void TSelectorDraw::Begin(TTree *tree)
} else {
hp = new TProfile2D(hname, htitle.Data(), fNbins[2], fVmin[2], fVmax[2], fNbins[1], fVmin[1], fVmax[1], "");
}
hp->SetDirectory(gDirectory);
if (!hkeep) {
hp->SetBit(kCanDelete);
if (!opt.Contains("goff")) hp->SetDirectory(nullptr);
Expand All @@ -826,6 +830,7 @@ void TSelectorDraw::Begin(TTree *tree)
h2 = (TH2F*)fOldHistogram;
} else {
h2 = new TH2F(hname, htitle.Data(), fNbins[1], fVmin[1], fVmax[1], fNbins[0], fVmin[0], fVmax[0]);
h2->SetDirectory(gDirectory);
h2->SetLineColor(fTree->GetLineColor());
h2->SetLineWidth(fTree->GetLineWidth());
h2->SetLineStyle(fTree->GetLineStyle());
Expand Down Expand Up @@ -859,6 +864,7 @@ void TSelectorDraw::Begin(TTree *tree)
} else {
h3 = new TH3D(hname, htitle.Data(), fNbins[2], fVmin[2], fVmax[2], fNbins[1], fVmin[1], fVmax[1], fNbins[0], fVmin[0], fVmax[0]);
}
h3->SetDirectory(gDirectory);
h3->SetLineColor(fTree->GetLineColor());
h3->SetLineWidth(fTree->GetLineWidth());
h3->SetLineStyle(fTree->GetLineStyle());
Expand Down
Loading