[ntuple] improve reading of std::vector<complex object>#21651
Open
jblomer wants to merge 1 commit intoroot-project:masterfrom
Open
[ntuple] improve reading of std::vector<complex object>#21651jblomer wants to merge 1 commit intoroot-project:masterfrom
jblomer wants to merge 1 commit intoroot-project:masterfrom
Conversation
When reading std::vector of non-trivial object, use the capacity information of the vector: if the new number of elements fits in the capacity, assume that no reallocation takes place. Previously, any size increase assumed reallocation. This makes the std::vector reading identical to the RVec reading wrt. number of constructor/destructor calls of the collection item.
Test Results 22 files 22 suites 3d 1h 48m 45s ⏱️ Results for commit 74c3ccf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading std::vector of non-trivial object, use the capacity information of the vector: if the new number of elements fits in the capacity, assume that no reallocation takes place. Previously, any size increase assumed reallocation.
This makes the std::vector reading identical to the RVec reading wrt. number of constructor/destructor calls of the collection item.